Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FATES API update for SPITFIRE refactor #6762

Merged
merged 3 commits into from
Jan 10, 2025
Merged

FATES API update for SPITFIRE refactor #6762

merged 3 commits into from
Jan 10, 2025

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Nov 21, 2024 •
edited by bishtgautam
Loading

Updates fates to API37 per a fates-side fire refactor which renames and moves nfsc.
This updates the fates tag with a number of fates-side fixes and feature updates so
fates tests will be answer changing.

Fixes #6806
[non-B4B] for fates tests

@glemieux
FATES API update to capture fuel class refactor
da584a6 
This commit updates fates to API37 which is necessary to capture
renaming per a fates-side fire refactor
@glemieux glemieux added the FATES label Nov 21, 2024
@glemieux glemieux changed the title FATES API update to capture fuel class refactor FATES API update for fuel class refactor Nov 21, 2024
@glemieux glemieux changed the title FATES API update for fuel class refactor FATES API update for SPITFIRE refactor Nov 21, 2024
@rljacob rljacob added the elm land model label Nov 21, 2024
@glemieux
Copy link
Contributor Author

Regression testing against e3sm_land_developer baseline underway on perlmutter.

@bishtgautam bishtgautam self-requested a review November 28, 2024 03:47
@glemieux
Copy link
Contributor Author

glemieux commented Dec 2, 2024

Regression testing on perlmutter with the e3sm_land_developer suite against the master baseline is complete. Test results are b4b for all non-fates tests as expected. FATES diffs are showing up with very low differences against baseline (i.e. E-23) for FATES_CBALANCE_ERROR and FATES_ERROR_EL.

This is good to integrate.

@rljacob
Copy link
Member

rljacob commented Dec 19, 2024

notes: ready to go.

bishtgautam added a commit that referenced this pull request Jan 9, 2025
@bishtgautam
Merge branch 'lnd/fates-api37' into next (PR #6762)
7fd9e62 
Updates fates to API37 per a fates-side fire refactor which renames and moves `nfsc`.
This updates the fates tag with a number of fates-side fixes and feature updates so
fates tests will be answer changing.

Fixes #6806
[non-B4B] for fates tests
@bishtgautam
Copy link
Contributor

@glemieux FATES tests did not show a DIFF when this PR was merged to next. Are there no FATES tests with SPITFIRE turned on?

@glemieux
Copy link
Contributor Author

glemieux commented Jan 9, 2025 •
edited
Loading

@bishtgautam most of the fates tests run with spitfire on. If they inherit the fates testmod, spitfire will be on in its simplest mode:

E3SM/components/elm/cime_config/testdefs/testmods_dirs/elm/fates/user_nl_elm

Line 5 in 24eea85

fates_spitfire_mode = 1

I'm surprised that no diffs showed up in the merge to next, since I was seeing expected diffs per #6762 (comment). Is e3sm_land_developer included in the test list for this stage of the integration?

Just to clarify, I don't expect there to be diffs due to the spitfire refactor, but due to updating the fates tag which includes a number of interstitial fates updates.

@rljacob
Copy link
Member

rljacob commented Jan 9, 2025

Yes e3sm_land_developer is included in e3sm_developer which is then included in e3sm_integration.
I notice there's a suite called "fates" which has additional tests that aren't in e3sm_developer or integration.

@rljacob
Copy link
Member

rljacob commented Jan 10, 2025

@glemieux Perlmutter gnu is showing diffs on some FATES tests. Were you using gnu when you saw them?

@glemieux
Copy link
Contributor Author

@rljacob sorry for the delayed response. Good clarification: Yes that's correct. I ran both intel and gnu for e3sm_land_developer and I'm seeing DIFFs only on the gnu tests.

  DIFF ERS_Ld20.f45_f45.IELMFATES.pm-cpu_gnu.elm-fates
  DIFF SMS_Ld20.f45_f45.IELMFATES.pm-cpu_gnu.elm-fates_eca
  DIFF SMS_Ld5_PS.f19_g16.IELMFATES.pm-cpu_gnu.elm-fates_cold

@bishtgautam bishtgautam merged commit 13abf59 into E3SM-Project:master Jan 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishtgautam bishtgautam bishtgautam approved these changes

Assignees

@bishtgautam bishtgautam

Labels
elm land model FATES Land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ELM-FATES harvest mode option character length is too short
3 participants
@glemieux @rljacob @bishtgautam